Re: [PATCH] input: wrong irq requested in edt-ft5x06.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Stefano,

On Wed, Sep 19, 2012 at 04:53:54PM +0200, Stefano Babic wrote:
> The probe function checks for integrity the pdata->irq_pin,
> but then does not request this line for interrupt.
> For this reason, no interrupts are generated.
> 
> Tested on a AM3517 board with EP0700M06

Why is your board code does not set client->irq properly?

Thanks.

> 
> Signed-off-by: Stefano Babic <sbabic@xxxxxxx>
> CC: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> CC: Simon Budig <simon.budig@xxxxxxxxxxxxxxxxx>
> CC: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
>  drivers/input/touchscreen/edt-ft5x06.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
> index b06a5e3..9608281 100644
> --- a/drivers/input/touchscreen/edt-ft5x06.c
> +++ b/drivers/input/touchscreen/edt-ft5x06.c
> @@ -788,7 +788,8 @@ static int __devinit edt_ft5x06_ts_probe(struct i2c_client *client,
>  	input_set_drvdata(input, tsdata);
>  	i2c_set_clientdata(client, tsdata);
>  
> -	error = request_threaded_irq(client->irq, NULL, edt_ft5x06_ts_isr,
> +	error = request_threaded_irq(gpio_to_irq(pdata->irq_pin), NULL,
> +				     edt_ft5x06_ts_isr,
>  				     IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
>  				     client->name, tsdata);
>  	if (error) {
> -- 
> 1.7.9.5
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux