Re: HID: hid-multitouch: Switch to device groups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 8 Aug 2012, Henrik Rydberg wrote:

> > > > This is a semi-automatic email about new static checker warnings.
> > > > 
> > > > The patch 4fa3a5837b84: "HID: hid-multitouch: Switch to device 
> > > > groups" from May 1, 2012, leads to the following Smatch complaint:
> > > > 
> > > > drivers/hid/hid-multitouch.c:735 mt_probe()
> > > > 	 error: we previously assumed 'id' could be null (see line 694)
> > > 
> > > Yes, and the same patch also removes the reason 'id' could be null.
> > 
> > Great.  Could you remove the unneeded check in mt_probe() and give
> > me a Reported-by: tag?
> 
> Ok, now I get it - I was pretty sure that test was not in mainline
> anymore, but obviously I was wrong. Jiri, here is a patch for it, at
> your convenience.

Applied, thanks Dan, thanks Henrik.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux