Hello Henrik Rydberg, This is a semi-automatic email about new static checker warnings. The patch 4fa3a5837b84: "HID: hid-multitouch: Switch to device groups" from May 1, 2012, leads to the following Smatch complaint: drivers/hid/hid-multitouch.c:735 mt_probe() error: we previously assumed 'id' could be null (see line 694) drivers/hid/hid-multitouch.c 693 694 if (id) { ^^^^ Old check. 695 for (i = 0; mt_classes[i].name ; i++) { 696 if (id->driver_data == mt_classes[i].name) { 697 mtclass = &(mt_classes[i]); 698 break; 699 } 700 } 701 } 702 [snip] 733 mt_post_parse(td); 734 735 if (id->vendor == HID_ANY_ID && id->product == HID_ANY_ID) ^^^^^^^^^^ New dereference removed a check. 736 mt_post_parse_default_settings(td); 737 regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html