Ping Cheng wrote: > I feel very bad about the issue. More testing should have been done > among us during the development. Since the patch was touched by more > than one people at linuxwacom.sf.net project, we most likely did not > test TPC2FG devices after last person's change. It's not really about testing. A patch adding MTSCREEN support simply should not touch the non-MTSCREEN cases at all. It can make perfect sense to have some preparatory changes that affect other devices, as earlier patches in the same series. And I don't think it's your fault --- others on the linux-input@ list could have caught it. [...] > All in all, I am very sorry about the problem. But reverting back > isn't as easy as it sounds since we have many patches built on it now. > Using your patch requires us the same amount of time to test on other > devices, which does not help us move forward. > > So, I propose we make a patch that fixes the issue upstream. Yeah, that works for me. But please be more careful in the future. Thanks, Jonathan -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html