On Mon, Jun 11, 2012 at 11:40 PM, Joao Paulo Rechi Vita <jprvita@xxxxxxxxxxxxx> wrote: > On Mon, Jun 11, 2012 at 2:56 PM, David Herrmann > <dh.herrmann@xxxxxxxxxxxxxx> wrote: >> Hi Joao >> >> On Mon, Jun 11, 2012 at 4:46 PM, Joao Paulo Rechi Vita >> <jprvita@xxxxxxxxxxxxx> wrote: >>> On Sun, Jun 10, 2012 at 10:16 AM, David Herrmann >>> <dh.herrmann@xxxxxxxxxxxxxx> wrote: >>>> This adds a new low-level HID driver that allows user-space to implement the >>>> transport-layer. This is needed by HOGP (HID over Gatt on Bluetooth Low Energy). >>>> There is already an implementation of HOGP, see the >>>> linux-bluetooth@xxxxxxxxxxxxxxx mailing list for this. >>>> >>>> I've split this into multiple patches to make review easier. This patchset is >>>> already working for several months for the HOGP developers but there may still >>>> be some issues with it. Please review. >>>> >>>> The uhid_*() functions implement the basic module functionality. The >>>> uhid_char_*() functions handle character-device related functionality. The >>>> uhid_dev_*() functions handle the uhid-device object and the uhid_hid_*() >>>> functions are HID-callbacks. >>>> >>>> I am open for any suggestions. >>>> >>> >>> Hello David, >>> >>> I've noticed one regression from the patch you've sent without Feature >>> Reports support to the one with Feature Reports support (which was the >>> previous patch, before the split) with the events coming from the char >>> device. The event_type values we're all coming out of its enum type >>> range. Have you tested this lately, with this new patch? I'll apply >>> and test it right now. >> >> I don't understand. What do you mean with "are all coming out of its >> enum type range"? Are the type values incorrect and not the ones >> defined in uhid.h? >> > > Exactly, the "event_type" field if of type "enum uhid_event_type", > which ranges from 0 to 10. The values coming from the char device are > numbers with around 10-12 digits. > (sorry, I forgot to cc the list on the original response) I've tested this new version split in several patches. Input reports support works fine, but the event_type value is still broken. This is a minor issue IMO, since it just affects output and feature reports support, which is not completed implemented in the userspace side of HoG yet. I don't see a problem in having the series integrated upstream and we fix this problem later on. -- João Paulo Rechi Vita Openbossa Labs - INdT -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
