Re: [PATCH 00/16] HID: uhid: User-space HID I/O driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Joao

On Mon, Jun 11, 2012 at 4:46 PM, Joao Paulo Rechi Vita
<jprvita@xxxxxxxxxxxxx> wrote:
> On Sun, Jun 10, 2012 at 10:16 AM, David Herrmann
> <dh.herrmann@xxxxxxxxxxxxxx> wrote:
>> This adds a new low-level HID driver that allows user-space to implement the
>> transport-layer. This is needed by HOGP (HID over Gatt on Bluetooth Low Energy).
>> There is already an implementation of HOGP, see the
>> linux-bluetooth@xxxxxxxxxxxxxxx mailing list for this.
>>
>> I've split this into multiple patches to make review easier. This patchset is
>> already working for several months for the HOGP developers but there may still
>> be some issues with it. Please review.
>>
>> The uhid_*() functions implement the basic module functionality. The
>> uhid_char_*() functions handle character-device related functionality. The
>> uhid_dev_*() functions handle the uhid-device object and the uhid_hid_*()
>> functions are HID-callbacks.
>>
>> I am open for any suggestions.
>>
>
> Hello David,
>
> I've noticed one regression from the patch you've sent without Feature
> Reports support to the one with Feature Reports support (which was the
> previous patch, before the split) with the events coming from the char
> device. The event_type values we're all coming out of its enum type
> range. Have you tested this lately, with this new patch? I'll apply
> and test it right now.

I don't understand. What do you mean with "are all coming out of its
enum type range"? Are the type values incorrect and not the ones
defined in uhid.h?

> --
> João Paulo Rechi Vita
> Openbossa Labs - INdT

Thanks for testing
David
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux