On Thu, Mar 15, 2012 at 07:03:12PM -0700, Chase Douglas wrote:
> On 03/15/2012 06:52 PM, Thorsten Wissmann wrote:
> > It turned out xf86-input-evdev really discards all non-multitouch events
> > (especially ABS_X and ABS_Y) events in EvdevProcessAbsoluteMotionEvent()
> > in evdev.c, if the device is configured as a multitouch device. So there
> > is a quick fix (or only workaround?), which processes ABS_X and ABS_Y
> > events even if it is a multitouch device:
> >
> > diff --git a/src/evdev.c b/src/evdev.c
> > index d540b87..b857b83 100644
> > --- a/src/evdev.c
> > +++ b/src/evdev.c
> > @@ -832,7 +832,7 @@ EvdevProcessAbsoluteMotionEvent(InputInfoPtr pInfo,
> > struct input_event *ev)
> > if (ev->code >= ABS_MT_SLOT) {
> > EvdevProcessTouchEvent(pInfo, ev);
> > pEvdev->abs_queued = 1;
> > - } else if (!pEvdev->mt_mask) {
> > + } else if (!pEvdev->mt_mask || ev->code == ABS_X || ev->code ==
> > ABS_Y) {
> > map = pEvdev->axis_map[ev->code];
> > valuator_mask_set(pEvdev->vals, map, value);
> > pEvdev->abs_queued = 1;
> >
> > This patch already is submitted to the xorg bugtracker and can be found
> > at [1].
> >
> > The only remaining question is: Does it break other drivers?
> >
> > [1] https://bugs.freedesktop.org/show_bug.cgi?id=47382
>
> Great!
>
> I haven't fully thought about it enough to give a reviewed-by, but it
> seems sane.
>
> I suggest sending the patch to xorg-devel@xxxxxxxxxxx. That's where most
> patch reviews are handled. You will likely get faster results there.
I have sent it to xorg-devel@xxxxxxxxxxx. (I haven't noticed it, because
only the web-bugtracker is noted in the README)
Thank you very much
Max
Thorsten
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
