On Fri, Feb 24, 2012 at 02:28:25PM +0530, deepaksi wrote: > Hi, > > > On 2/24/2012 2:04 PM, Dmitry Torokhov wrote: > >On Thu, Feb 23, 2012 at 03:10:51PM +0530, Viresh Kumar wrote: > >>From: Deepak Sikri<deepak.sikri@xxxxxx> > >> > >>This patch handles the fix for unbalanced irq for the cases when > >>enable_irq_wake fails, and a warning related to same is displayed > >>on the console. The workaround is handled at the driver level. > >So why is the device marked as wakeup capable? > > The device is capable of wake up. There are cases in which the > enable_irq_wake call may fail. In this case I'd say the proper action would be to abort suspend instead of continuing. > This was specifically observed for ARM cortex architecture kernel > implementation for GIC (PL390). > The 2.6.37 kernel versions and before do not have the callbacks > related to function that help to set up > the wake up interrupts in GIC, and enable_irq_wake returns with an > error code -ENXIO. Right, but current mainline does have it set up properly, correct? IOW we do not really expect enable_irq_wake() to fail if device is wakeup capable, correct? Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
