Re: [PATCH 1/2] Input/spear-keyboard: Fix for balancing the enable_irq_wake in Power Mgmt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,


On 2/24/2012 2:04 PM, Dmitry Torokhov wrote:
On Thu, Feb 23, 2012 at 03:10:51PM +0530, Viresh Kumar wrote:
From: Deepak Sikri<deepak.sikri@xxxxxx>

This patch handles the fix for unbalanced irq for the cases when
enable_irq_wake fails, and a warning related to same is displayed
on the console. The workaround is handled at the driver level.
So why is the device marked as wakeup capable?

The device is capable of wake up. There are cases in which the enable_irq_wake call may fail.

This was specifically observed for ARM cortex architecture kernel implementation for GIC (PL390). The 2.6.37 kernel versions and before do not have the callbacks related to function that help to set up the wake up interrupts in GIC, and enable_irq_wake returns with an error code -ENXIO.

Now if the user tries to disable the wake up interrupts in the resume routines without checking in for the cases where the enable_irq_wake failed, kernel returns a warning related to unbalanced irq as we are trying to disable
an interrupt which was not enabled.

However, in case the enable_irq_wake is successful ( as was in case of ARM9 architectures with VIC callbacks present for setting up wake up interrupts present), this check allowed to keep track of success cases.



Regards
Deepak
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux