Re: [PATCH] Set buttonpad property bit on bcm5974 devices.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jussi,

> diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c
> index 5ec617e..7c69d9e 100644
> --- a/drivers/input/mouse/bcm5974.c
> +++ b/drivers/input/mouse/bcm5974.c
> @@ -876,6 +876,7 @@ static int bcm5974_probe(struct usb_interface *iface,
>  
>  	input_dev->name = "bcm5974";
>  	input_dev->phys = dev->phys;
> +	__set_bit(INPUT_PROP_BUTTONPAD, input_dev->propbit); 
>  	usb_to_input_id(dev->udev, &input_dev->id);
>  	/* report driver capabilities via the version field */
>  	input_dev->id.version = cfg->caps;

Only macbooks from 2010 and later have the integrated touchpad, so
this has clearly not been broadly tested. Please use the
HAS_INTEGRATED_BUTTON property to steer the logic right.

Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux