Re: [PATCH] edt_ts: EDT Touchscreen driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ilya,

On Thu, 17 Nov 2011 00:44:17 +0400
Ilya Yanok <yanok@xxxxxxxxxxx> wrote:

> Hi Dmitry, Anatolij,
> 
> On 15.11.2011 21:41, Dmitry Torokhov wrote:
> >>> Do you really need to read gpio state in IRQ? Can't you simply rely on
> >>> 'event' do decide whether to emit input events?
> >>
> >> We can't rely on the 'event' only. The peculiar behaviour of the
> >> touch controller enforces this. The touch controller toggles the
> >> interrupt line when you keep the finger down. The rate is not exactly
> >> specified by the the manufacturer (~80/sec). Measured rate deviates
> >> from this specified rate. Valid touch packet data can be read when
> >> interrupt line is pulled down.
> > 
> > So what ensures that the gpio line stays low between the check and the
> > time you get access to i2c bus and get around reading the data.
> 
> Anatolij, could you please comment on this? What can we do about this?
> Check the pin state after i2c read maybe?

I received a suggestion to look at the time elapsed since falling
edge of the GPIO IRQ before reading the touch packet data and
skip reading if it is too late. I'll also check what the touch
packet data looks like when reading it while finger is down but
the line stays high. 

Anatolij
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux