Hi Dmitry, On 14.11.2011 21:28, Dmitry Torokhov wrote: >> + irq = gpio_to_irq(pdata->irq_gpio); >> + if (irq < 0) { >> + dev_err(&client->dev, "can't get IRQ for GPIO\n"); >> + error = -EINVAL; >> + goto err0; >> + } > > Why can't we use client->irq? Well, my idea was to avoid duplication (passing both GPIO and IRQ numbers) and I can't pass only client->irq as we need GPIO number also and irq_to_gpio is not guaranteed to work with arbitrary IRQ number. Thanks for your comments! I'll address them and repost the patch. Regards, Ilya. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html