I have no problem doing that; I'll rework the patch. Thanks! -- Terry On Fri, Oct 14, 2011 at 2:30 AM, Jiri Kosina <jkosina@xxxxxxx> wrote: > > On Thu, 13 Oct 2011, Terry Lambert wrote: > > > Hi Jiri; thanks for looking so promptly! > > > > The routine right now just caches the hi->input for later look up > > during the raw input report, which I suppose could be done inline on > > each report with a couple function calls. > > Well yes, but even in px_raw_event() the px_device *px is only > initialized, but never used. So I'd just remove the whole px_device thing > altogether, I don't think it's needed. > > > I don't have one of the folding keyboards people are complaining about > > not being able to use for Android tablets on hand, or the unhappy Dell > > Inspiron laptop, both of which use the controller That's to explain > > why the remapping code and the product ID for them are missing from > > this patch. > > I see. > > I'd like to ask you though to only submit patches containing code that is > actually used. Whenever the remapping part is needed for some other > keyboard, we'll just add it at the very time it's needed. > > Thanks, > > -- > Jiri Kosina > SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
