On Mon, Jul 18, 2011 at 10:02:44AM -0700, Dmitry Torokhov wrote: > On Monday, July 18, 2011 09:45:07 AM Shawn Guo wrote: > > The patch makes a copy of platform data into driver data, so that any > > reference to platform_data after .probe exits can be avoided. > > And why is this beneficial? I am of the opinion that platform data should > stay on (and be accessed through a const pointer to ensure that the driver > will not alter it). > To me, it's a common sense that platform data should not be referenced after .probe exits, so that any platform code providing the data can claim the data as __initconst. When we build multiple platforms which all have their own platform data for gpio_keys in the kernel, there is only one of them will be used by gpio_keys driver, others should be freed after init, no? -- Regards, Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
