On Monday, July 18, 2011 10:15:27 AM Grant Likely wrote: > On Mon, Jul 18, 2011 at 11:02 AM, Dmitry Torokhov > > <dmitry.torokhov@xxxxxxxxx> wrote: > > On Monday, July 18, 2011 09:45:07 AM Shawn Guo wrote: > >> The patch makes a copy of platform data into driver data, so that any > >> reference to platform_data after .probe exits can be avoided. > > > > And why is this beneficial? I am of the opinion that platform data > > should stay on (and be accessed through a const pointer to ensure > > that the driver will not alter it). > > Because when using the device tree, there is no platform_data. > So allocate it... That's what Davids patch does. BTW, you never gave ACK for the final version and I'd prefer to have it for the DT bindings. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
