Re: [PATCH v5] input: Initial support for Kionix KXTJ9 accelerometer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 29, 2011 at 01:39:41PM +0100, Jonathan Cameron wrote:
> On 06/28/11 20:12, chris.hudson.comp.eng@xxxxxxxxx wrote:
> > +static int kxtj9_input_open(struct input_dev *input)
> > +{
> > +	struct kxtj9_data *tj9 = input_get_drvdata(input);
> > +
> > +	return kxtj9_enable(tj9);
> return kxtj9_enable(input_get_drvdata(input));

Actually I prefer limiting use of void pointers. If kxtj9_enable()
changes to take something other than "struct kxtj9_data *" then original
will issue a warning while the proposed form will happily accept it.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux