Hello,
Thanks to both of you for your comments.
Op 17-05-11 07:44, Dmitry Torokhov schreef:
On Mon, May 16, 2011 at 01:15:52PM +0200, Henrik Rydberg wrote:
Hi Éric,
:
Excellent work, thank you so much. A couple of tiny tiny details:
[patch 1]
+In the wild, there appear to be more versions, such as 04.03.01, 04.04.11. There
+appear to be almost no difference excepted the EF113 which do not report
no difference, except
Indeed... I'll try to fix it in another patch.
[patch 3]
@@ -100,14 +100,22 @@ struct elantech_data {
unsigned char reg_26;
unsigned char debug;
unsigned char capabilities;
- bool paritycheck;
+ unsigned char paritycheck;
bool jumpy_cursor;
+ unsigned char reports_pres :1;
unsigned char hw_version;
unsigned int fw_version;
unsigned int single_finger_reports;
unsigned char parity[256];
};
Any particular reason to use unsigned char instead of bool here, and to
restrict report_pres to a single bit? Bool for both seems apt.
paritycheck became a type (between 0-3), that's why it can't be bool.
Anyway, this was dropped by Dmitry.
reports_pres would make much more sense as a bool, you are completely right!
:
Thank you for working on this. I applied patches 1 and 4-6; 3rd required
some changes but since they were minor I retained Henrik's reviewed-by.
I am not happy with the protocol checks from Dell, I am not sure they
make much sense; so I dropped patch 3 for now and because of that patch
2 did not make much sense either. Actually patch 2 did not make sense on
its own in any case as it should have been partially rolled into 3 and
partially into 4.
Thanks for tweaking the patches. I don't mind dropping patch 3. I had
just implemented what was in the other driver, but I let you judge
whether it's meaningful. At least on my hardware, I never noticed the
detection of any error with them, anyway :-)
I'll try to update and resend patch 2.
See you,
Éric
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
