On Mon, May 16, 2011 at 01:15:52PM +0200, Henrik Rydberg wrote:
> Hi Éric,
>
> > Here is an update of patches which I had sent quite a few monthes
> > ago. At this time they were a bit controversial because the hardware
> > reports only the minimum/maximum positions when two fingers are
> > pressed. With the "semi-mt" property from Henrik that should now be
> > well handled.
> >
> > The first few patches of this set should also add support for a few
> > more hardware versions. I could not test all the hardware versions
> > but it's based on the old Dell/Ubuntu driver and if it goes into
> > Linus's tree during the merge window I'm confident we can catch and
> > easily fix regressions :-)
>
> Excellent work, thank you so much. A couple of tiny tiny details:
>
> [patch 1]
>
> +In the wild, there appear to be more versions, such as 04.03.01, 04.04.11. There
> +appear to be almost no difference excepted the EF113 which do not report
>
> no difference, except
>
> [patch 3]
>
> @@ -100,14 +100,22 @@ struct elantech_data {
> unsigned char reg_26;
> unsigned char debug;
> unsigned char capabilities;
> - bool paritycheck;
> + unsigned char paritycheck;
> bool jumpy_cursor;
> + unsigned char reports_pres :1;
> unsigned char hw_version;
> unsigned int fw_version;
> unsigned int single_finger_reports;
> unsigned char parity[256];
> };
>
> Any particular reason to use unsigned char instead of bool here, and to
> restrict report_pres to a single bit? Bool for both seems apt.
>
> Other than the above, which do not really need a resend, feel free to add
>
> Reviewed-by: Henrik Rydberg <rydberg@xxxxxxxxxxx>
>
> on all six patches. Thank you, Éric.
>
Eric,
Thank you for working on this. I applied patches 1 and 4-6; 3rd required
some changes but since they were minor I retained Henrik's reviewed-by.
I am not happy with the protocol checks from Dell, I am not sure they
make much sense; so I dropped patch 3 for now and because of that patch
2 did not make much sense either. Actually patch 2 did not make sense on
its own in any case as it should have been partially rolled into 3 and
partially into 4.
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
