On Wed, May 04, 2011 at 09:42:32AM +0300, Igor Grinberg wrote: > On 05/03/11 19:18, Dmitry Torokhov wrote: > > > On Tue, May 03, 2011 at 07:02:53PM +0300, Igor Grinberg wrote: > >> The pendown gpio was requested but not configured for input. > >> Request and configure it in one shot. > >> > >> Signed-off-by: Igor Grinberg <grinberg@xxxxxxxxxxxxxx> > > There is no significant change from the previos version of the patch by > > Sourav Poddar that I tried to apply and had to revert. Does it compile > > if !CONFIG_GENERIC_GPIO? > > shout!?!? It has been just several month we had this discussion, > but I've completely forgot it took place... shame on me... > > Back to business, either way, the gpio direction must be configured > before accessing the gpio. > I can propose two solutions to this: > 1) ads7846 relies on gpio subsystem, so add depend on > CONFIG_GENERIC_GPIO to Kconfig ads7846 entry. > 2) just don't use gpio_request_one(), > but gpio_request() and then gpio_direction_input(). > > Logic behind 1 is that platforms that don't use CONFIG_GENERIC_GPIO > most likely don't use ads7846. Anybody know of such platform? > The second one is less intrusive and more local, but will do the job. > > What do you think is more preferable? I'd prefer adding gpio_direction_input(). While I do not know of instances where ads7846 is used without CONFIG_GENERIC_GPIO it does not mean they do not exist. Thanks, -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
