On Tue, May 03, 2011 at 07:02:53PM +0300, Igor Grinberg wrote:
> The pendown gpio was requested but not configured for input.
> Request and configure it in one shot.
>
> Signed-off-by: Igor Grinberg <grinberg@xxxxxxxxxxxxxx>
There is no significant change from the previos version of the patch by
Sourav Poddar that I tried to apply and had to revert. Does it compile
if !CONFIG_GENERIC_GPIO?
> ---
> drivers/input/touchscreen/ads7846.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
> index c24946f..bf067aa 100644
> --- a/drivers/input/touchscreen/ads7846.c
> +++ b/drivers/input/touchscreen/ads7846.c
> @@ -956,7 +956,8 @@ static int __devinit ads7846_setup_pendown(struct spi_device *spi, struct ads784
> ts->get_pendown_state = pdata->get_pendown_state;
> } else if (gpio_is_valid(pdata->gpio_pendown)) {
>
> - err = gpio_request(pdata->gpio_pendown, "ads7846_pendown");
> + err = gpio_request_one(pdata->gpio_pendown, GPIOF_IN,
> + "ads7846_pendown");
> if (err) {
> dev_err(&spi->dev, "failed to request pendown GPIO%d\n",
> pdata->gpio_pendown);
> --
> 1.7.3.4
>
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
