Re: [PATCH] Add a driver to support InvenSense mpu3050 gyroscope chip.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alan,

On Wed, Mar 09, 2011 at 01:47:51PM +0000, Alan Cox wrote:
> From: Joseph Lai <joseph_lai@xxxxxxxxxxx>
> 
> This driver is registered as an input device with sysfs control
> interface, but it still can output 3 axes data in non-interrupt mode.
> 
> This is primarily an input device but can also be used as for other things.
> It thus exposes the power control (so you can keep power on when you want) and
> x/y/z co-ordinates directly.

I'd be more happy if it was just an input device. If non-wired interrupt
is a common case then we should probably add polled input device mode,
but we certainly should not register completely non-functional input
device as the driver does now.

We also have a way of retrieving current (or rather most recent)
coordinates via EVIOCGABS so I am not sure why we want the sysfs way of
retrieving coordinates as well.

Regarding power mode - I really believe that this should be done on the
driver core level instead of implementing "manual off" in every single
driver out there.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux