On Fri, Mar 11, 2011 at 10:52:55AM +0100, Benjamin Tissoires wrote: > Hi Richard, > > On Fri, Mar 11, 2011 at 10:23, Richard Nauber > <richard.nauber@xxxxxxxxxxxxxx> wrote: > >>On Fri, Mar 11, 2011 at 7:53 AM, Benjamin Tissoires > >><benjamin.tissoires@xxxxxxxxx> wrote: > >> Hi Richard, > >> > >> I'm really sorry, but it's a NACK for me: > >> what ever Henrik said, I do not want to have numerical constants > >> throughout the code. It would be the open door to many others. The > >> reason we have "mt_class" is to regroup each per-device parameters in > >> it. So there is no need to introduce those constants everywhere. > > > > Hm, so should I make a patch that applies on top of Henriks "Send > > events per slot if CONTACTCOUNT is missing" and uses the generic XY > > fixup of my v3 patch? > > > > I would say so. Please just change the name of the field .axis by a better name. I disagree with this approach. The code in question is per device bug, not per device. The next firmware bug might be that the axis are shifted, or that the value is given with wrong byte order, we just don't know. Until we know what the next bug has in common with the old ones, let's be simple. Henrik -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
