Re: [PATCH v3] [input-hid] Add hid-egalax driver to the unified hid-multitouch framework.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Richard,

On Fri, Mar 11, 2011 at 10:23, Richard Nauber
<richard.nauber@xxxxxxxxxxxxxx> wrote:
>>On Fri, Mar 11, 2011 at 7:53 AM, Benjamin Tissoires
>><benjamin.tissoires@xxxxxxxxx> wrote:
>> Hi Richard,
>>
>> I'm really sorry, but it's a NACK for me:
>> what ever Henrik said, I do not want to have numerical constants
>> throughout the code. It would be the open door to many others. The
>> reason we have "mt_class" is to regroup each per-device parameters in
>> it. So there is no need to introduce those constants everywhere.
>
> Hm, so should I make a patch that applies on top of Henriks "Send
> events per slot if CONTACTCOUNT is missing"  and uses the generic XY
> fixup of my v3 patch?
>

I would say so. Please just change the name of the field .axis by a better name.

Cheers,
Benjamin
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux