On Fri, Feb 11, 2011 at 2:40 PM, Ping Cheng <pinglinux@xxxxxxxxx> wrote: > On Fri, Feb 11, 2011 at 12:24 PM, Ping Cheng <pinglinux@xxxxxxxxx> wrote: >> On Fri, Feb 11, 2011 at 11:56 AM, Henrik Rydberg <rydberg@xxxxxxxxxxx> wrote: >>>> @@ -1180,7 +1144,6 @@ void wacom_setup_input_capabilities(struct input_dev *input_dev, >>>> input_abs_set_res(input_dev, ABS_Y, >>>> wacom_calculate_touch_res(features->y_max, >>>> features->y_phy)); >>>> - __set_bit(BTN_TOOL_DOUBLETAP, input_dev->keybit); >>> >>> Where is doubletap set now? >> >> Oops. I must have missed that in 4/4. I'll add it in the new version >> after I hear from you for the other comments. > > Well, DOUBLETAP has been added in 4/4 already. Please take a close > look. Too soon to admit an error ;). > Extra clarification on whats going on here: Patch #1 removes BTN_TOOL_TRIPLETAP; among other supporting 2 finger touch code. In that context, it was used as an awkward indication to xf86-input-wacom that device supported 2 finger touch. In this patch #3, it removes BTN_TOOL_DOUBLETAP; which was an awkward indication to xf86-input-wacom that device supports 1 finger touch. Once this patch is applied, applications must deduce touchscreen input supports 1 finger touch same way as they do for other touchscreens (not seeing BTN_TOOL_FINGER and no stylus related BTN_'s as well). Patch #4 adds BTN_TOOL_DOUBLETAP back but using normal meaning that the device supports 2 finger touch. I had reviewed this patch series in context of some related changes from Ping to xf86-input-wacom. I wanted to document doubletap part of that review on this list though. Ping originally didn't want to add that back in. At least one of the reasons was that there were no known applications that supported both "touchscreens" (absolute mode) and the BTN_TOOL_DOUBLETAP at same time. I did look around quite a bit after Ping's comment and I couldn't come up with anything (mtdev, xf86-input-evdev, etc). So its a good point. When something supports ABS_MT_*, thats given much more weight then BTN_TOOL_DOUPLETAP would; which is the case here. Anyways, I requested if Ping would add BTN_TOOL_DOUBLETAP in to align with current hid-ntrig and since it didn't seem to hurt and could possibly help some future app. Please double check me here if it is in fact a good idea to add DOUBLETAP in for touchscreens. Chris -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
