On Fri, Feb 04, 2011 at 12:23:14PM +0100, Henrik Rydberg wrote: > > Henrik> The code below will return -EINVAL even if some parts of the buffer > > Henrik> was successfully read, though. > > > > You mean written? I don't see that. The only place we return -EINVAL is > > at the initial check. > > Right, it should have been written, and -EFAULT, referring to the code > in the loop. > If we faulted somewhere midway the only sane thing it to treat the whole request as suspect and return -EFAULT. We really do not know what happened to the other data (it could have gone past the buffer user intended but haven't triggered the fault yet. We can't fully recover either since we aleady retrievend the event that caused fault. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
