On Thu, Jan 27, 2011 at 01:04:49PM +0100, Peter Korsgaard wrote: > >>>>> "Henrik" == Henrik Rydberg <rydberg@xxxxxxxxxxx> writes: > > Hi, > > Henrik> I won't argue against this case (with < 0) being frequent, but one > Henrik> should really check "n < len" to be safe. Hopefully Dmitry has some > Henrik> more input. > > No, the point is that write (and read) can consume less data than > requested, without it being an error. Robust userspace code should > adjust buffer address / size and redo the work until all data is > transferred or an error occurs. Shouldn't the error be on (!len || len % smallest_acceptable_chunk), then? Which makes me wonder about regressions - perhaps accumulating partial writes in evdev is more safe from that perspective. Thanks, Henrik -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
