Re: [PATCH 5/5] Add chip I2C addresses to header file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 04, 2011 at 10:37:43AM +0200, Iiro Valkonen wrote:

Please fix your mail client to word wrap within paragraphs, I've
reflowed your text for legibility.

> To help lazy developers, they don't have to dig up the datasheet to
> see what address their chip is at? Well, I guess they might have to do
> that anyway to see what address out of these is selected with the
> address select pin. I thought it would be neat to have all the
> possible addresses listed here, and the developer could pick the
> correct one for his/her board file. Or in the case where he is not
> sure about the state of the address select pin, maybe even try them
> all. 

If you're going to do this a comment in the driver describing what
addresses correspond to which device configurations - having it as a
bunch of #defines in the code is less discoverable and still requires
users to look up in the datasheet to see which address the device
actually has.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux