On Wed, Jan 05, 2011 at 10:41:46PM +0000, Mark Brown wrote: > On Wed, Jan 05, 2011 at 02:14:32PM -0800, Dmitry Torokhov wrote: > > > I do not think you tested it with !CONFIG_PM since &NULL is not valid > > expression (& requires an lvalue for operand). > > Oh, fail. I knew there was a reason why dev_pm_ops stuff caused hassle. > But then I do have to wonder who exactly builds without PM enabled these > days. Well, I kind of agree. Maybe someone should start looking into removing CONFIG_PM, we are in 2011 now... > > > Please change to guard .pm = &ad7879_i2c_pm with #ifdef. > > Meh, I guess. Though that ends up being annoying in general as some of > the PM functions (things like poweroff) are active even without PM > enabled, Most of the drivers do not need special handlers for poweroff though... I actually do not much liek the "simple" initializator as it usually does way more than needed. > it always feels clearer to just have the struct there all the > time and carry on with the standard NULLs for functions. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
