Re: [PATCH] Input: ad7879 - Convert I2C to dev_pm_ops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 05, 2011 at 02:14:32PM -0800, Dmitry Torokhov wrote:

> I do not think you tested it with !CONFIG_PM since &NULL is not valid
> expression (& requires an lvalue for operand).

Oh, fail.  I knew there was a reason why dev_pm_ops stuff caused hassle.
But then I do have to wonder who exactly builds without PM enabled these
days.  

> Please change to guard .pm = &ad7879_i2c_pm with #ifdef.

Meh, I guess.  Though that ends up being annoying in general as some of
the PM functions (things like poweroff) are active even without PM
enabled, it always feels clearer to just have the struct there all the
time and carry on with the standard NULLs for functions.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux