Re: [PATCH 3/3 v2] input - wacom_w8001: Add one finger touch support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 2, 2011 at 1:01 AM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
> On Thu, Dec 30, 2010 at 10:25:20AM -0800, Ping Cheng wrote:
>> On Wed, Dec 29, 2010 at 2:30 PM, Ping Cheng <pinglinux@xxxxxxxxx> wrote:
>> > Dmitry,
>> >
>> > Thank you for your effort in updating the patch. Most changes work for
>> > me. I do have comments related to raw touch data scaling for MT and
>> > single touch legacy client support. Details are inline.
>>
>> After revisited the change you made, I think I can accept both
>> suggestions. The legacy client support may introduce issue. But it
>> won't hurt too much, I hope ;).  The MT scaling offers a consistent
>> support between one and two finger touch, which is good.
>>
>> So, the only change left is to scale the raw x,y of 2FGT to max_pen. I
>> can make a version 3 of this patch for you or you can change those two
>> lines if you don't mind. Just let me know.
>
> If there are such devices that have pen + 2FGT then please adjust the
> patch as you should be able to test it ;)

Yes, there are pen + 2FGT devices in the market now. Will update the patch soon.

> Also, if you [re]send me inputattach part for 8001 I shoudl try adding
> it to inputattach (it's not there yet, is it?).

No, inputattach is not part of this patchset. I am not sure which
inputattach.c source my patch should be based on. The one under your
repo looks a bit old....

Ping
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux