On Thu, Dec 02, 2010 at 04:04:35PM +0100, Jiri Kosina wrote: > On Tue, 30 Nov 2010, Greg KH wrote: > > > > > Using pack pragma to prevent padding bytes in binary data structures > > > > used for hardware communication. Explanation of these pragmas was requested. > > > [...] > > > > > > It would be clearer to use the '__packed' macro after each structure > > > definition instead of using this awful Microsoft extension. > > > > I agree, that's the "normal" Linux way of doing things. > > > > Other than that, this patch set looks good to me. Jiri, if the packed > > change is made, do you want me to take these through my tree, or do you > > want to take them through yours? Whatever is easier for you is fine > > with me. > > Hi Greg, > > as this is part of larger roccat patchset, I will be processing it through > my tree once completely reviewed. Great, feel free to add my: Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx> to the driver core changes. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
