Hi Dmitry, > On Wed, Nov 24, 2010 at 04:01:34PM -0500, Ben Gardiner wrote: >> These are just some suggested changes from the review in patch-form. I will >> do my best to make time for reviewing and testing any future versions of the >> patch that you submit but I will regrettably be moving to other projects >> for awhile. Until then I will not be able to spend much time on integration. >> >> With these patches applied I was able to build the da850-evm buttons and keys >> support with minimal changes.As I said, these are just suggested changes, >> please feel free to squash, edit or drop them as you see fit. My motivation >> here is that if you pickup the driver name and config symbol names as-is then >> I will have no remaining integration to perform in the da850-evm series. I >> hope you don't mind that I have to patch and run here. >> >> I look forward to your next version of the patch. > > I do like the original patch and even more so Ben changes. Could you > tell me if the following still works for you (goes on top of Ben's) > and if it does I'll fold everything together and queue for 2.6.38. It works for me, however I have additional fixes on top of Ben's changes. I will post an updated version soon. The original driver was a part of a patch-set which adds support for a new MIPS platform. There are a couple of patches in that series which requires this one. It would be nice if the driver would be able to go through the MIPS tree to avoid cross-tree dependencies. Regards, Gabor -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html