These are just some suggested changes from the review in patch-form. I will do my best to make time for reviewing and testing any future versions of the patch that you submit but I will regrettably be moving to other projects for awhile. Until then I will not be able to spend much time on integration. With these patches applied I was able to build the da850-evm buttons and keys support with minimal changes.As I said, these are just suggested changes, please feel free to squash, edit or drop them as you see fit. My motivation here is that if you pickup the driver name and config symbol names as-is then I will have no remaining integration to perform in the da850-evm series. I hope you don't mind that I have to patch and run here. I look forward to your next version of the patch. Best Regards, Ben Gardiner --- Nanometrics Inc. http://www.nanometrics.ca Ben Gardiner (6): fixup gpio_buttons: use the same debounce_interval member found in gpio_key to obtain a threshold count based on polling interval fixup gpio_buttons: use existing gpio_keys_button structure instead of introducing new gpio_button structure fixup gpio_buttons: detect and error-out if a button is requested for wakeup fixup gpio_buttons: show units of poll_interval platform data member fixup gpio_buttons: move gpio_buttons.c to drivers/input/keyboard from drivers/input/misc fixup gpio_buttons : rename gpio-buttons / gpio_buttons to gpio-keys-polled / gpio_keys_polled drivers/input/keyboard/Kconfig | 16 ++++ drivers/input/keyboard/Makefile | 2 + .../gpio_buttons.c => keyboard/gpio_keys_polled.c} | 86 +++++++++++--------- drivers/input/misc/Kconfig | 16 ---- drivers/input/misc/Makefile | 1 - .../linux/{gpio_buttons.h => gpio_keys_polled.h} | 15 +--- 6 files changed, 69 insertions(+), 67 deletions(-) rename drivers/input/{misc/gpio_buttons.c => keyboard/gpio_keys_polled.c} (64%) rename include/linux/{gpio_buttons.h => gpio_keys_polled.h} (60%) -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
