On Wed, Nov 10, 2010 at 11:30:25AM -0200, Mauro Carvalho Chehab wrote: > Em 10-11-2010 04:51, Dmitry Torokhov escreveu: > > On Tue, Nov 09, 2010 at 08:21:34AM -0200, Mauro Carvalho Chehab wrote: > >> Em 09-11-2010 04:32, Dmitry Torokhov escreveu: > >>> On Mon, Nov 08, 2010 at 12:14:48PM -0200, Mauro Carvalho Chehab wrote: > >>>> Em 08-11-2010 11:41, jonsmirl@xxxxxxxxx escreveu: > >>>>> On Mon, Nov 8, 2010 at 8:34 AM, jonsmirl@xxxxxxxxx <jonsmirl@xxxxxxxxx> wrote: > >>>>>> To achieve plug and play at least one of four choices has to happen: > >>>>> > >>>>> There is another option, the IR maps get integrated into user space > >>>>> keyboard mapping package. This may be possible with the new > >>>>> libxkbcommon package. > >>>> > >>>> That seems interesting. > >>>> > >>> > >>> I disagree here. libxkbcommon provides X interface while applications > >>> might want to access evdev nodes directly. > >> > >> Let me express better: I don't think we should integrate X with the udev tool, > >> but, eventually, we could make some X package dependent of v4l-utils. Not sure > >> if libxkbdcommon is the better way to do it, as I don't have it installed here > >> on my machines. > >> > >>> If anything, parts of > >>> ir-utils dealing with keymap selection should be moved into udev. Maybe > >>> we should split utilities that select protocol from the keymap setting > >>> and use udev keymap utilities to do the task. > >> > >> It doesn't make sense to split keymap and protocol selection. Just loading a > >> keyboard table but not changing the IR protocol is useless, as the device will > >> not be selected. Besides that, the tool that do both is really simple (and, btw, > >> it also allows changing the map for a non-RC device, by using one parameter that > >> skips the usage of the sysfs nodes at /sys/class/rc): > >> > >> # ir-keytable -d /dev/input/event4 -r > >> scancode 0x0000 = KEY_LEFTCTRL (0x1d) > >> Enabled protocols: > > > > OTOH loading keymap and selecting protocol are 2 distinct actions and > > udev already has a tool to load keymaps that should also work for all > > devices, including remotes. > > How this tool decide what scancode should be associated with a remote controller? > There are, currently, 86 different keytables, one for each known bundled remote, > and the decision about what keymap should be load needs to take some hints provided > via RC sysfs nodes, in order to get the right table. And udev has access to this data, hasn't it? Once proper keymap is identified the generic tool can load it, it does not matter whether target device is an RC or a keypad. > > The two distinct actions are not independent. A keycode table should dictate what > protocol is needed, as the same device can support more than one protocol, and the > in-hardware decoders will only produce scancodes if the protocol is properly selected. > So, the udev tool needs to do both actions at the same time. Or udev could call 2 utilities. First would select the protocol and second would load the keymap. This is actually main Unix principle - do one thing and do it well instead of trying to make a swiss army knife-type program. > > > Basically I do not see the reason for having 2 tools doing pretty much > > the same thing. > > We may replace the old tool, or merge both tools, but the point is that the > needs are different. For example, for Remote Controllers, before loading a keytable, > the tool needs to clean-up the previous table, as the bundled keyboard (or a previous keytable > load) may map different scancodes than the ones that exist at the newer table. Then, > it needs to select the protocol and load the new keytable. > > Also, for Remote Controllers, kernel provides some additional hints at /sys/class/rc/rc?/uevent, > specifying the name of the real driver that is loading the device and the name of > the bundled remote. Those info should be taken into account, in order to select the > proper keycode table. > > On the other side, a tool to change those things at runtime is also needed. So, what I did > to avoid tools duplication is that I've added everything needed by Remote Controllers > at the very same tool, preventing duplication. See above. But anyway, I think we already spent too much time discussing this point, if you decide to merge with used - fine, if not - it's OK too ;) Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
