Hi Abraham - You mentioned you are using the OMap kernel. Is that the 2.6.29 for the Omap2/3 or the 2.6.32 for the Omap4? The reason I ask is that this code probably won't compile on versions of the kernel earlier than 2.6.31 due to architectural changes that were done to i2c. Thanks, William Manson Synaptics, Inc. -----Original Message----- From: Arce, Abraham [mailto:x0066660@xxxxxx] Sent: Tuesday, October 12, 2010 12:07 AM To: linux-input@xxxxxxxxxxxxxxx; Dmitry Torokhov Cc: William Manson; Allie Xiong; Christopher Heiny; Jean Delvare Subject: input: Synaptics touchscreen driver followup Hi, This is a follow up on http://www.spinics.net/lists/linux-input/msg11163.html I have started to work with synaptics-rmi4 branch using sdp4430 board with 2 TM1217 controllers. I am right now using linux-omap-2.6 kernel After some modifications and board configuration changes I was able to register all rmi layers however I am still facing some issues, will continue debugging - Compilation error when built as modules - Interrupts not being generated but registered - In polling mode, kernel crash when ts_work_func is executed If anyone has made some other progress I'll be glad to test changes... Dmitry, I have 2 questions, 1. Is it ok to send patches for cleanup or do you prefer functional ones? There are some checkpatch warnings still around 2. Could you please explain more about bus implementation? I have read Documentation/driver-model/bus.txt and wrote some initial code to register rmi as a bus, giving # ls /sys/bus/rmi/drivers/ # ls /sys/bus/rmi/devices/ >From this point, I am confused on where bus will be in the picture shared by Synaptics team, shown below... - Does it mean RMI4 Driver will be RMI4 bus and we will keep same application on top of it? - What about i2c and spi layers? They will be drivers for rmi bus? - What will be a device for rmi bus? The application? +----------------------------------------+ | Application | +----------------------------------------+ | RMI4 Driver | Data Layer | (this file) | +-----+-----+-------+----------+---------+ | I2C | SPI | SMBus | etc. | Physical Layer +-----+-----+-------+----------+---------+ Thanks for the guidance! Best Regards Abraham -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html