On Wed, Oct 06, 2010 at 12:09:39AM +0200, Linus Walleij wrote: > This wrapper function will accept non-existing regulators and > not treat them as errors. Consumers will have to NULL-check their > regulators. No, this is actively unhelpful. If consumers can null check their regulators then they can just as well do an IS_ERR() check and if we just eat null pointers like this then the API doesn't degrade gracefully when it can't implement things - for example, your regulator_set_voltage() will report success when it fails to set a voltage which is going to upset any consumer that thinks it did actually change the current voltage. The existing dummy regulator support already does all this in a manner which is much less invasive for the core. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
