Hi Sundar, > > These registers are for the SKE Keypad - Scroll Key Encoder and Keypad modules. The > scroll key encoder too shares them and hence in the header file. Let's keep the only ones which are shared and not all. I am not sure about the scroll key encoder driver location. > > Okay. > >> Can you please clarify why you need thread? Looking at the code, I don't think that >> we have any need of creating thread. request_irq(...) should work just fine. > > Yes it can. I am seeing increasing tendency to migrate to threaded_irq from the legacy irq recently > and hence the threaded request. > Use threaded_irq only when needed with different flags and not everywhere. In this case we don't need threaded irq at all. ---Trilok Soni -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html