Hi Trilok, >-----Original Message----- >From: Trilok Soni [mailto:tsoni@xxxxxxxxxxxxxx] > >More description about the keypad controller please. > Okay. >Is it Onchip on the NomaDik or over PMIC? > As stated in the Kconfig option, it is on the Nomadik and U8500 platforms. Anyways, I will update the commit message for more description. >> +/* register definitions for SKE peripheral */ > >Why they need to be in the header? These registers #define can be moved to .c file. > These registers are for the SKE Keypad - Scroll Key Encoder and Keypad modules. The scroll key encoder too shares them and hence in the header file. >> + return; > >No need. > Okay. >Can you please clarify why you need thread? Looking at the code, I don't think that >we have any need of creating thread. request_irq(...) should work just fine. Yes it can. I am seeing increasing tendency to migrate to threaded_irq from the legacy irq recently and hence the threaded request. >> + device_init_wakeup(&pdev->dev, true); > >Can you make this pdata? > Okay. >> +MODULE_AUTHOR("Naveen Kumar G/Sundar Iyer"); > >Care to add e-mail address? > Okay. Dmitry, apart from Trilok's comments above, is there anything else you want me to re-spin? Regards, Sundar -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
