On Fri, Sep 03, 2010 at 12:40:51PM +0530, Trilok Soni wrote:
> Hi Sundar,
>
> > +
> > + info->idev->name = "AB8500 POn(PowerOn) Key";
>
> nit-pick: having spaces in the name would create hard time parsing it. Though it all
> depends on the userspace framework.
I am not sure what kind of parsing you have in mind but we have always
set name attribute to something readable:
[dtor@dtor-d630 ~]$ cat /proc/bus/input/devices | grep Name=
N: Name="Lid Switch"
N: Name="Power Button"
N: Name="Sleep Button"
N: Name="Macintosh mouse button emulation"
N: Name="AT Translated Set 2 keyboard"
N: Name="Video Bus"
N: Name="Dell WMI hotkeys"
N: Name="HDA Intel Mic at Ext Left Jack"
N: Name="HDA Intel HP Out at Ext Left Jack"
N: Name="Dell Premium USB Optical Mouse"
N: Name="Lite-On Technology USB Productivity Option Keyboard( has the hub in # 1 )"
N: Name="Lite-On Technology USB Productivity Option Keyboard( has the hub in # 1 )"
N: Name="ImExPS/2 Generic Explorer Mouse"
I think I might even slip a space between "POn" and "(PowerOn)".
>
> > +
> > +static struct platform_driver ab8500_ponkey_driver = {
> > + .driver = {
> > + .name = "ab8500-poweron-key",
> > + .owner = THIS_MODULE,
> > + },
> > + .probe = ab8500_ponkey_probe,
> > + .remove = __devexit_p(ab8500_ponkey_remove),
>
> It is not must for this driver to go through, but what would be the behaviour of
> pwr-key on suspend and resume? Do you want power key to wakeup the system from sleep?
> OR don't want to make it as wakeup source?
I am about to apply the patch so if you decide to do any PM changes they
shoudl go as a separete path please.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
