On Tue, 2010-08-31 at 00:36 -0400, Michael Poole wrote: > On Tue, 2010-08-31 at 00:31 -0400, Michael Poole wrote: > > On Mon, 2010-08-30 at 13:20 -0400, Chase Douglas wrote: > > > The trackpad speaks a similar, but different, protocol from the magic > > > mouse. However, only small code tweaks here and there are needed to make > > > basic multitouch work. > > > > > > Extra logic is required for single-touch emulation of the touchpad. The > > > changes made here take the approach that only one finger may emulate the > > > single pointer when multiple fingers have touched the screen. Once that > > > finger is raised, all touches must be raised before any further single > > > touch events can be sent. > > > > > > Sometimes the magic trackpad sends two distinct touch reports as one big > > > report. Simply splitting the packet in two and resending them through > > > magicmouse_raw_event ensures they are handled properly. > > > > > > I also added myself to the copyright statement. > > > > > > Signed-off-by: Chase Douglas <chase.douglas@xxxxxxxxxxxxx> > > > > I have no technical concerns with the patch, just two questions. (Once > > I get the chance to test it, I expect to add my Acked-by.) > > Actually, one thing slipped my mind. This patch does not apply cleanly > to Jiri's for-next tree, because the not-yet-upstream commit 7d876c05fa > changes the context at hid-magicmouse.c's line 290 before this patch. > Manually munging the context allows the commit to apply. Could you > rebase this patch on a tree that contains that commit? An oversight on my part. I'll rebase onto Jiri's for-next tree and resubmit. Thanks, -- Chase -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
