On Tue, Jun 15, 2010 at 6:08 PM, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > On Tue, Jun 15, 2010 at 05:55:46PM +0200, Manuel Lauss wrote: >> If the AC97 controller implements the ->setgpio callback, use it. >> Some codecs (i.e. WM9712) only accept GPIO data through AC97 slot 12. >> >> Signed-off-by: Manuel Lauss <manuel.lauss@xxxxxxxxxxxxxx> > > It seems like it'd be easier to just do this as a generic AC'97 thing > rather than adding it to the WM97xx driver - that way any CODEC that has > GPIO support can use it, we don't have to add custom per-CODEC GPIO APIs. > If you're using the WM97xx-specific code you're already doing something > custom so it's not much loss to use a generic thing. Oh, now I get it. Hmm, what about setting pin direction? That certainly is per-codec, no? Manuel -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
