Re: [PATCH RFC 2/3] input: wm97xx: set GPIOs with AC97 GPIO busops if implemented

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 15, 2010 at 05:55:46PM +0200, Manuel Lauss wrote:
> If the AC97 controller implements the ->setgpio callback, use it.
> Some codecs (i.e. WM9712) only accept GPIO data through AC97 slot 12.
> 
> Signed-off-by: Manuel Lauss <manuel.lauss@xxxxxxxxxxxxxx>

It seems like it'd be easier to just do this as a generic AC'97 thing
rather than adding it to the WM97xx driver - that way any CODEC that has
GPIO support can use it, we don't have to add custom per-CODEC GPIO APIs.
If you're using the WM97xx-specific code you're already doing something
custom so it's not much loss to use a generic thing.

Like I said in reply to the previous mail super bonus fun points for
doing it in terms of gpiolib.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux