Hi, On Fri, Jun 11, 2010 at 12:21:02PM +0100, Mark Brown wrote: > On Fri, Jun 11, 2010 at 12:13:15PM +0200, Luotao Fu wrote: > > > +/* > > + * reference source: > > + * > > + * Set ref_sel = 0 for internal reference > > + * ref_sel = 1 for external reference > > + */ > > +static int ref_sel; > > +module_param(ref_sel, int, 0444); > > +MODULE_PARM_DESC(ref_sel, > > + "Set ADC reference source. Default is 0 (internal reference)"); > > This looks like something that ought to be configured via platform data > since the value that should be used is going to be determined by the > board schematic. Similar comments apply to most of the other module > parameters, though in some cases sysfs files might be more appropriate > as well, or in addition. OK. These stuffs are indeed platform dependent. I'll create a platform data for it than. Thanks Luotao Fu -- Pengutronix e.K. | Dipl.-Ing. Luotao Fu | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: Digital signature
