On Fri, Jun 11, 2010 at 12:13:15PM +0200, Luotao Fu wrote: > +/* > + * reference source: > + * > + * Set ref_sel = 0 for internal reference > + * ref_sel = 1 for external reference > + */ > +static int ref_sel; > +module_param(ref_sel, int, 0444); > +MODULE_PARM_DESC(ref_sel, > + "Set ADC reference source. Default is 0 (internal reference)"); This looks like something that ought to be configured via platform data since the value that should be used is going to be determined by the board schematic. Similar comments apply to most of the other module parameters, though in some cases sysfs files might be more appropriate as well, or in addition. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
