Re: [RFC/RFT] Synaptics -

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 21, 2010 at 03:45:40PM +0200, Takashi Iwai wrote:
> At Tue, 20 Apr 2010 23:11:17 -0700,
> Dmitry Torokhov wrote:
> > 
> > Newer Synaptics firmware allows to quesry maximim dimensions reported by
> > device, let's use this data.
> > 
> > Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx>
> > ---
> > 
> > Takashi,
> > 
> > I would appreciate if you could give this patch a try.
> 
> The bit definition seems wrong:
> 
> > @@ -51,6 +52,7 @@
> >  #define SYN_CAP_MULTI_BUTTON_NO(ec)	(((ec) & 0x00f000) >> 12)
> >  #define SYN_CAP_PRODUCT_ID(ec)		(((ec) & 0xff0000) >> 16)
> >  #define SYN_CAP_CLICKPAD(ex0c)		((ex0c) & 0x100100)
> > +#define SYN_CAP_MAX_DIMENSIONS(ex0c)	((ex0c) & 0x02)
> 
> This should be
> 
> 	#define SYN_CAP_MAX_DIMENSIONS(ex0c)	((ex0c) & 0x020000)
> 

You are right. I forgot we shift the bytes around...

> After changing this, it seems working fine.
> The area is detected as 5584 x 4618.
> 

Great! Thank you.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux