Re: [PATCH] Input: add appleir USB driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 19, 2010 at 11:08:10AM +0100, Bastien Nocera wrote:
> On Mon, 2010-04-19 at 00:28 -0700, Dmitry Torokhov wrote:
> > On Mon, Apr 19, 2010 at 01:31:49AM +0100, Bastien Nocera wrote:
> > > On Sun, 2010-04-18 at 13:19 -0700, Dmitry Torokhov wrote:
> > > <snip>
> > > > > > Hmm, I am curious why suspend and resume is not necessary for this
> > > > > > device... Are you relying on the USB core to tear down and re-create the
> > > > > > device? Then you may lose user-applied settings (like changed keymap).
> > > > > 
> > > > > How could I test that?
> > > > 
> > > > Change the keymap (with keyfuzz or something similar), suspend. resume and see 
> > > > if the mapping persisted.
> > > 
> > > Tried using udev's keymap tool on it, but the default get function
> > > doesn't give me any output.
> > > 
> > > Am I supposed to implement get/setkeycode myself for this to work, or
> > > should the default input functions work? If the latter, is there
> > > anything missing in the driver for me to call to enable that?
> > > 
> > > Trying to set a keycode says that the "EVIOCSKEYCODE" ioctl returns
> > > EINVAL.
> > > 
> > 
> > As I said in an earlier e-mail:
> > 
> > > ... also set up input_dev->keycode, keycodemax and keycodesize so that
> > > keymap can be adjusted from userspace on per-device basis.
> 
> I missed that bit, sorry.
> 
> I tested udev's keymap, and the keymap isn't being saved across
> suspend/resume cycles. I re-added the _suspend() and _resume() calls
> (and their definitions in the usb_driver struct), but the keymap still
> disappears.

Do you see another instance of the device appearing in dmesg?

> 
> Is there anything else I would need to do in this case to keep the
> device (and its keymap) around during suspend?
> 
> I'm guessing that this problem wouldn't matter too much because udev
> would re-apply any keymaps it had for the device when it reappears, and
> in the lirc case, the keymap is in user-space.

That assumes that user does use udev. Extremely likely, but still not certain.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux