On Sunday 18 April 2010 12:49:37 pm Bastien Nocera wrote: > On Sun, 2010-04-18 at 12:43 -0700, Dmitry Torokhov wrote: > > On Sat, Apr 17, 2010 at 10:44:55PM +0100, Bastien Nocera wrote: > > > On Sat, 2010-04-17 at 01:12 -0700, Dmitry Torokhov wrote: > > > > HI Bastien, > > > > > > > > On Fri, Apr 16, 2010 at 05:19:52PM +0100, Bastien Nocera wrote: > > > > > This driver was originally written by James McKenzie, updated by > > > > > Greg Kroah-Hartman, further updated by myself, with suspend support > > > > > added. > > > > > > > > > > More recent versions of the IR receiver are also supported through > > > > > a patch by Alex Karpenko. > > > > > > > > > > Tested on a MacbookAir1,1 > > > > > > > > A few comments... > > > > > > All fixed. I removed the suspend/resume code as it worked fine without > > > it (I was working of an old patch). > > > > > > Sent the new patch separately. > > > > Hmm, I am curious why suspend and resume is not necessary for this > > device... Are you relying on the USB core to tear down and re-create the > > device? Then you may lose user-applied settings (like changed keymap). > > How could I test that? Change the keymap (with keyfuzz or something similar), suspend. resume and see if the mapping persisted. > > > But if suspend and resume are really not needed then you need to > > complete cleanup and get rid of APPLIEIR_OPENED and APPLEIR_SUSPENDED > > and their handling in applieir_open() and appleir_close(). > > My mistake. I'll clean that up now. > > > Right. I was just saying that Jiri needs to either take HID parts > > through his tree or give OK for me to take through mine. > > OK. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
