On Thu, Feb 11, 2010 at 10:10:35PM -0500, Rafi Rubin wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > >> + input_event(input, EV_ABS, ABS_MT_TOUCH_MAJOR, 0); > >> + input_event(input, EV_ABS, ABS_MT_TOUCH_MINOR, 0); > >> + input_mt_sync(input); > >> + } > >> + } > > > > Where's the final input_sync()? And if hid does it for us (I think it does) > > then syncs above are not needed. > > It seems the normal input_sync calls are unnecessary for the single touch device. > > The mt syncs are necessary to separate each contact. And since we are caching the > contacts we need to emit those. The final normal input_sync is handled by hid. > > On a side note, once I pulled the st input syncs, the mt device stopped getting them. > I had to undo the blocking of CONTACTCOUNT which restores the normal syncs from hid. Ah, these are 2 different devices... I need to increase my coffee intake. OK, so I re-read the patch again and it you are splittig the one physical device in 2 - one legacy single tap and another multi-touch. If I understand it correctly that means that the same gesture can be potentially sent through bnoth devices. So in this case how system should decide which device to use and which device to ignore? -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
