Re: [PATCH 3/4] hid-ntrig.c Split multi and single touch.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>> +			input_event(input, EV_ABS, ABS_MT_TOUCH_MAJOR, 0);
>> +			input_event(input, EV_ABS, ABS_MT_TOUCH_MINOR, 0);
>> +			input_mt_sync(input);
>> +		}
>> +	}
> 
> Where's the final input_sync()? And if hid does it for us (I think it does)
> then syncs above are not needed.

It seems the normal input_sync calls are unnecessary for the single touch device.

The mt syncs are necessary to separate each contact.  And since we are caching the
contacts we need to emit those.  The final normal input_sync is handled by hid.

On a side note, once I pulled the st input syncs, the mt device stopped getting them.
I had to undo the blocking of CONTACTCOUNT which restores the normal syncs from hid.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkt0xqgACgkQwuRiAT9o6081+wCfe5K5LRJXr0jORoTJPOVwCrXT
V7YAn1ijdSwMSyenvPU9wy3QfJyodDJS
=UZmW
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux