On ven, 2010-01-29 at 22:37 +0100, Uwe Kleine-König wrote:
> Hello Alberto,
>
> On Fri, Jan 29, 2010 at 10:18:46PM +0100, Alberto Panizzo wrote:
> > The MXC family of Application Processors is shipped with a Keypad Port
> would you mind to do s/MXC/IMX/ in your patch? Currently both are used
> but we (=Sascha and me) will try to deprecate MXC.
For sure! and for what I can say I approve this plan.
>
> > + * >>Power management need to be implemented<<.
> s/need/needs/ (or alternatively do it :-) and maybe s/<<\./.<</ ?
hehe, power management is the next part. What I wont is to put the
device running before the next merge window if it is possible and
then present all my work on mx31_3ds.
>
> > [...]
> > +
> > + /* The matrix is stable only if no changes are detected after
> > + * MXC_KEYPAD_SCANS_FOR_STABILITY scans */
> unusual format of the comment.
>
> /*
> * ...
> * ...
> */
>
> is the most found way in the kernel for multi-line comments.
Only a way to compress them..
>
> > [...]
> > +MODULE_LICENSE("GPL v2");
> There is no space expected in the string passed to MODULE_LICENSE.
Thanks.
Alberto!
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
